Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk.

View Change

4 comments:

• File libflashrom.h:

  • Patch Set #22, Line 129: };

    Please move to the commit that makes use of it.

    Done

  • Patch Set #22, Line 131: const struct flashrom_flashctx *, struct flashrom_wp_chip_config *

    Something about APIs in general. We are used to have the destination […]

    Done - here and in other files/commits. I think I got all occurrences, let me know if I missed something :)

• File writeprotect.c:

  • Patch Set #22, Line 48: **

    Library functions should be in a respective documentation group, e.g. @defgroup or @addtogroup.

    Done

  • Patch Set #22, Line 122: INVALID_REG

    IMO it is a bit confusing when loop starts with "invalid" value. […]

    Done

To view, visit change 58479. To unsubscribe, or for help writing mail filters, visit settings.