Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45431 )
Change subject: tests: Clear ID cache before trying to fetch chip ID a second time ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/45431/1/tests/spi25.c File tests/spi25.c:
https://review.coreboot.org/c/flashrom/+/45431/1/tests/spi25.c@132 PS1, Line 132: clear_spi_id_cache();
Shouldn't this be done everywhere?
perhaps? This is the only place where it's _needed_ though, so that's where I stopped. In fact, it may be useful to extend the test to check the cache functionality as well (that is, do the same twice and check that the second run doesn't call into spi_send_command at all).