View Change
1 comment:
File tests/spi25.c:
Patch Set #1, Line 132: clear_spi_id_cache();
Shouldn't this be done everywhere?
perhaps? This is the only place where it's _needed_ though, so that's where I stopped. In fact, it may be useful to extend the test to check the cache functionality as well (that is, do the same twice and check that the second run doesn't call into spi_send_command at all).
To view, visit change 45431. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba6a56774ce5b51e0f7072b4600a9479cdabf8c7
Gerrit-Change-Number: 45431
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 15 Sep 2020 18:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment