[flashrom-gerrit] [M] Change in flashrom[main]: libflashrom: Update the API for progress callback

[Sergii Dmytruk (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes.

Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )

Change subject: libflashrom: Update the API for progress callback
......................................................................

Patch Set 7: Code-Review+2

(3 comments)

File include/libflashrom.h:

https://review.coreboot.org/c/flashrom/+/86031/comment/8fcb378d_0cb23789?usp... :
PS7, Line 112:  */
The comment should probably have a note saying that this has priority over `flashrom_set_progress_callback()` when both are set.  Not that it's very useful, but makes behaviour of the API less ambiguous.

File libflashrom.c:

https://review.coreboot.org/c/flashrom/+/86031/comment/ab9b1128_0a47fce7?usp... :
PS7, Line 76: 			  " ignoring this call since %s is deprecated\n",
nit: there is already a space on the previous line

https://review.coreboot.org/c/flashrom/+/86031/comment/25cc92c2_4a797814?usp... :
PS7, Line 134: 			sizeof(flashctx->progress_state.user_data));
nit: Why use `memcpy()`?  Types match, so simple assignments should do and will break if types change, while `memcpy()` might not notice it.