Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes.

Patch set 7:Code-Review +2

View Change

3 comments:

• File include/libflashrom.h:

  • Patch Set #7, Line 112: */

    The comment should probably have a note saying that this has priority over `flashrom_set_progress_callback()` when both are set. Not that it's very useful, but makes behaviour of the API less ambiguous.

• File libflashrom.c:

  • Patch Set #7, Line 76: " ignoring this call since %s is deprecated\n",

    nit: there is already a space on the previous line

  • Patch Set #7, Line 134: sizeof(flashctx->progress_state.user_data));

    nit: Why use `memcpy()`? Types match, so simple assignments should do and will break if types change, while `memcpy()` might not notice it.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.