[flashrom-gerrit] [M] Change in flashrom[main]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME

[Peter Marheine (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Martin L Roth, Martin Roth, Nikolai Artemiev, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.

Peter Marheine has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email )

Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
......................................................................

Patch Set 10: Code-Review+2

(1 comment)

Patchset:

PS10: 
I don't see copies of the datasheet on the list; it looks like they may have been sent to you privately, since I see a message in reply blocks that looks like it had them attached? I was able to find a copy of the -512ME datasheet to look at, though (and assume the -256E is basically just a 256Mb version).
> Especially whether my comment is correct, that BP4 in datasheets works as TB.

Looks correct to me, since table 3 of the -512ME datasheet illustrates that pretty clearly (and I compared against EN25QH32 to verify the polarity was interpreted the same).