Attention is currently required from: Anastasia Klimchuk, Angel Pons, Martin L Roth, Martin Roth, Nikolai Artemiev, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.
Patch set 10:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #10:
I don't see copies of the datasheet on the list; it looks like they may have been sent to you privately, since I see a message in reply blocks that looks like it had them attached? I was able to find a copy of the -512ME datasheet to look at, though (and assume the -256E is basically just a 256Mb version).
Especially whether my comment is correct, that BP4 in datasheets works as TB.
Looks correct to me, since table 3 of the -512ME datasheet illustrates that pretty clearly (and I compared against EN25QH32 to verify the polarity was interpreted the same).
To view, visit change 58025. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0
Gerrit-Change-Number: 58025
Gerrit-PatchSet: 10
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com>
Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi@intel.corp-partner.google.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Attention: Raj Astekar <raj.astekar@intel.com>
Gerrit-Comment-Date: Mon, 20 May 2024 00:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>