Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 )
Change subject: meson: relocate config_print_wiki & config_default_programmer_* ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64029/comment/5f18177e_22f1958a PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"' I think we cannot drop it for our chromium use cases... I can double-check though. Let's not do anything in this patch :)
CONFIG_DEFAULT_PROGRAMMER_ARGS must be defined, at least as an empty string.
classic_cli.c:838
Yes but line 838 is under the condition on line 835 `if (default_programmer)`. So if name is empty then args not needed either? meson has this condition on line 411.