Attention is currently required from: Thomas Heijligen.

Patch set 3:Code-Review +2

View Change

1 comment:

• File meson.build:

  • Patch Set #2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'

    I think we cannot drop it for our chromium use cases... I can double-check though. Let's not do anything in this patch :)

    CONFIG_DEFAULT_PROGRAMMER_ARGS must be defined, at least as an empty string.
    classic_cli.c:838

    Yes but line 838 is under the condition on line 835 `if (default_programmer)`. So if name is empty then args not needed either?
    meson has this condition on line 411.

To view, visit change 64029. To unsubscribe, or for help writing mail filters, visit settings.