Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
David Reguera Garcia has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79299?usp=email )
Change subject: buspirate_spi: add support for hiz output with pullups=off ......................................................................
Patch Set 9:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/79299/comment/f2be117f_b4b877f9 : PS8, Line 12:
Since you merged two patches together, you can add a paragraph from the other patch here, you can ju […]
Done
Patchset:
PS9: all suggestions done (I hope)
File buspirate_spi.c:
https://review.coreboot.org/c/flashrom/+/79299/comment/27de89ef_46233fd7 : PS8, Line 374: if (strcasecmp("on", tmp) == 0) : pullup = true; : else if (strcasecmp("off", tmp) == 0) : ; // ignore : else { : msg_perr("Invalid pullups state. Use on/off.\n"); : free(tmp); : return 1; : }
For this if-else-elseif and the ones below: […]
Done
https://review.coreboot.org/c/flashrom/+/79299/comment/7246ec32_1c8f4047 : PS8, Line 390: else if (strcasecmp("off", tmp) == 0) : { : if (pullup) : {
I think this can be more compact: […]
Done
https://review.coreboot.org/c/flashrom/+/79299/comment/cfc7525a_2683bc8d : PS8, Line 394: pullups on & hiz off at same time is not possible
Just slightly add on this message: […]
Done