Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.

View Change

5 comments:

• Commit Message:

  • Patch Set #8, Line 12:

    Since you merged two patches together, you can add a paragraph from the other patch here, you can ju […]

    Done

• Patchset:

  • Patch Set #9:

    all suggestions done (I hope)

• File buspirate_spi.c:

  • Patch Set #8, Line 374:

    		if (strcasecmp("on", tmp) == 0)
    			pullup = true;
    		else if (strcasecmp("off", tmp) == 0)
    			; // ignore
    		else {
    			msg_perr("Invalid pullups state. Use on/off.\n");
    			free(tmp);
    			return 1;
    		}
    

    For this if-else-elseif and the ones below: […]

    Done

  • Patch Set #8, Line 390:

    		else if (strcasecmp("off", tmp) == 0)
    		{
    			if (pullup)
    			{
    

    I think this can be more compact: […]

    Done

  • Patch Set #8, Line 394: pullups on & hiz off at same time is not possible

    Just slightly add on this message: […]

    Done

To view, visit change 79299. To unsubscribe, or for help writing mail filters, visit settings.