Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c: Add functions for new erase selction algorithm ......................................................................
Patch Set 84:
(13 comments)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/eb3b7217_22ddeac1 PS83, Line 245: uint8_t* old_start_buf = (uint8_t*)malloc(old_start - region_start);
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/75f1783f_34c868d5 PS83, Line 268: //select erase functions
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/11ec5e07_f7c797b9 PS83, Line 268: //s
when you are going through code to check for line limit 112chars, try to add a space between `//` an […]
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/a2379325_ae82db4b PS83, Line 277: for (i = 0; i < erasefn_count; i++) {
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/3af1be5a_75020c69 PS83, Line 285:
comment is misaligned, too many tabs ?
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/c13fb12a_ef83e2cc PS83, Line 325: //adjust curcontents
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/c2433199_ec8090ee PS83, Line 336: *all_skipped = false;
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/8079dac2_c1d18645 PS83, Line 339: //write
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/d068288f_bc7e09bd PS83, Line 343:
trailing space (Gerrit shows it bright pink :))
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/513b4ddd_755402d4 PS83, Line 352: //adjust curcontents
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/05f68cf2_601fe515 PS83, Line 355: *all_skipped = false;
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/95cab8dc_47fd8f12 PS83, Line 366: free(old_start_buf);
new line before
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/b5e40493_37fde7f3 PS83, Line 368: msg_cinfo("Erase/write done from %x to %x\n", region_start, region_end);
new line before
Done