Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk.
13 comments:
File erasure_layout.c:
Patch Set #83, Line 245: uint8_t* old_start_buf = (uint8_t*)malloc(old_start - region_start);
new line before
Done
Patch Set #83, Line 268: //select erase functions
new line before
Done
when you are going through code to check for line limit 112chars, try to add a space between `//` an […]
Done
Patch Set #83, Line 277: for (i = 0; i < erasefn_count; i++) {
new line before
Done
comment is misaligned, too many tabs ?
Done
Patch Set #83, Line 325: //adjust curcontents
new line before
Done
Patch Set #83, Line 336: *all_skipped = false;
new line before
Done
Patch Set #83, Line 339: //write
new line before
Done
trailing space (Gerrit shows it bright pink :))
Done
Patch Set #83, Line 352: //adjust curcontents
new line before
Done
Patch Set #83, Line 355: *all_skipped = false;
new line before
Done
Patch Set #83, Line 366: free(old_start_buf);
new line before
Done
Patch Set #83, Line 368: msg_cinfo("Erase/write done from %x to %x\n", region_start, region_end);
new line before
Done
To view, visit change 65844. To unsubscribe, or for help writing mail filters, visit settings.