luke has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48949 )
Change subject: flashchips.c: Add support for XMC new spi flash types ......................................................................
Patch Set 5:
(8 comments)
fixed in patchset 5
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.h@814 PS1, Line 814:
two tabs needed to line up with the rest from the looks of it.
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@18994 PS1, Line 18994:
spurious tab, delete.
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19004 PS1, Line 19004: TEST_OK_PREW
Were these all tested? if not then you want `TEST_UNTESTED`. […]
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19070 PS1, Line 19070:
spurious tab, delete.
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19148 PS1, Line 19148:
spurious tab, delete.
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19149 PS1, Line 19149: {
too many braces, delete this one.
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19150 PS1, Line 19150:
spurious tab, delete.
Done
https://review.coreboot.org/c/flashrom/+/48949/1/flashchips.c@19192 PS1, Line 19192:
spurious tab, delete.
Done