fixed in patchset 5
View Change
8 comments:
File flashchips.h:
File flashchips.c:
Patch Set #1, Line 18994:
spurious tab, delete.
Done
Patch Set #1, Line 19004: TEST_OK_PREW
Were these all tested? if not then you want `TEST_UNTESTED`. […]
Done
Patch Set #1, Line 19070:
spurious tab, delete.
Done
Patch Set #1, Line 19148:
spurious tab, delete.
Done
Patch Set #1, Line 19149: {
too many braces, delete this one.
Done
Patch Set #1, Line 19150:
spurious tab, delete.
Done
Patch Set #1, Line 19192:
spurious tab, delete.
Done
To view, visit change 48949. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
Gerrit-Change-Number: 48949
Gerrit-PatchSet: 5
Gerrit-Owner: luke <sixuerain@qq.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Carl-Daniel Hailfinger <hailfinger@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Uwe Hermann <uwe@hermann-uwe.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 31 Dec 2020 14:29:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment