3 Nov
2020
3 Nov
'20
6:46 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46894 )
Change subject: test_build.sh: Move build test procedure to repository ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/46894/2/test_build.sh File test_build.sh:
https://review.coreboot.org/c/flashrom/+/46894/2/test_build.sh@2 PS2, Line 2: set -e
Recommended to use "Bash Strict Mode" […]
This script uses no pipes or variables.
https://review.coreboot.org/c/flashrom/+/46894/2/test_build.sh@7 PS2, Line 7: (cd out && ninja)
Why not add `out` directory to `. […]
Because people are free to use whatever build directory they want. Why add it?
--
To view, visit https://review.coreboot.org/c/flashrom/+/46894
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I37a8e925d1b283c3b8f87cb3d0f1ed8920f2cf95
Gerrit-Change-Number: 46894
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Septs github@septs.pw
Gerrit-Comment-Date: Tue, 03 Nov 2020 06:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Septs github@septs.pw
Gerrit-MessageType: comment