View Change

2 comments:

• File test_build.sh:

  • Patch Set #2, Line 2: set -e

    Recommended to use "Bash Strict Mode" […]

    This script uses no pipes or variables.

  • Patch Set #2, Line 7: (cd out && ninja)

    Why not add `out` directory to `. […]

    Because people are free to use whatever build directory they want. Why add it?

To view, visit change 46894. To unsubscribe, or for help writing mail filters, visit settings.