Attention is currently required from: Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62319 )
Change subject: tests/linux_spi: Validate param file path ......................................................................
Patch Set 4:
(3 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/62319/comment/e7c75e52_9263d45e PS4, Line 41: default_io_mock_state
The two implementations should be homogenised however there is too much code duplication in tests/ s […]
Ok, maybe multipath is not great name if it has a meaning already, let's think of other name. open_validate_paths?
I want to have more self-descriptive name, that's my main point. Just "default" doesn't explain anything. And self-descriptive name is even more important if such a function is defined somewhere in a different file and used throughout tests.
https://review.coreboot.org/c/flashrom/+/62319/comment/60a8337a_70175492 PS4, Line 43: 2
This could be made as a define, it's just the current max paths supported.
Yes, great idea to have it as define!
https://review.coreboot.org/c/flashrom/+/62319/comment/e7e1b75a_8a183176 PS4, Line 305: data
I am not so sure about this pattern, it looks very Java'ish with long variable names. […]
Ok, this is existing pattern that was reviewed and approved by everyone, that's why I suggested it. Maybe it's not perfect, alright. But then it needs to be changed in all tests. What I was usually doing in this situation was first patch to change existing tests, and then all the next can use "new style" (data as name, in this example).