Attention is currently required from: Edward O'Callaghan.
3 comments:
File tests/init_shutdown.c:
Patch Set #4, Line 41: default_io_mock_state
The two implementations should be homogenised however there is too much code duplication in tests/ s […]
Ok, maybe multipath is not great name if it has a meaning already, let's think of other name.
open_validate_paths?
I want to have more self-descriptive name, that's my main point. Just "default" doesn't explain anything. And self-descriptive name is even more important if such a function is defined somewhere in a different file and used throughout tests.
This could be made as a define, it's just the current max paths supported.
Yes, great idea to have it as define!
I am not so sure about this pattern, it looks very Java'ish with long variable names. […]
Ok, this is existing pattern that was reviewed and approved by everyone, that's why I suggested it.
Maybe it's not perfect, alright. But then it needs to be changed in all tests. What I was usually doing in this situation was first patch to change existing tests, and then all the next can use "new style" (data as name, in this example).
To view, visit change 62319. To unsubscribe, or for help writing mail filters, visit settings.