Attention is currently required from: Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55714/comment/b890ce1c_2965033c PS1, Line 7: ACPI
What part of the code is about ACPI? Sure, the EC data/control I/O register pair is described in ACP […]
Please take a look at: https://uefi.org/specs/ACPI/6.4/12_ACPI_Embedded_Controller_Interface_Specif... I dare to say it is standard ACPI EC because: - it uses status and data register layout defined in section "12.2. Embedded Controller Register Descriptions" - it uses default command set for writing and reading bytes from EC as described in the section "12.3. Embedded Controller Command Set" This is what this patch implements, the default command set. Even the Linux kernel calls it the ACPI Embedded Controller: https://github.com/torvalds/linux/blob/master/drivers/acpi/ec.c