Attention is currently required from: Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: ACPI
What part of the code is about ACPI? Sure, the EC data/control I/O register pair is described in ACP […]
Please take a look at: https://uefi.org/specs/ACPI/6.4/12_ACPI_Embedded_Controller_Interface_Specification/ACPI_Embedded_Controller_Interface_Specification.html I dare to say it is standard ACPI EC because:
- it uses status and data register layout defined in section "12.2. Embedded Controller Register Descriptions"
- it uses default command set for writing and reading bytes from EC as described in the section "12.3. Embedded Controller Command Set"
- This is what this patch implements, the default command set. Even the Linux kernel calls it the ACPI Embedded Controller: https://github.com/torvalds/linux/blob/master/drivers/acpi/ec.c
To view, visit change 55714. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bae8d81c80ae2f286b619e974869e3f2f4545d
Gerrit-Change-Number: 55714
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 21 Jun 2021 10:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment