Attention is currently required from: Edward O'Callaghan, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52473 )
Change subject: s25f.c: Fix mismatched function definitions ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52473/comment/b4fca2f9_3e513208 PS1, Line 8: : This was missed because `uint32_t` is `unsigned int` in most cases. : However, it is not the case for DJGPP 6.1.0 for some reason.
this does not sit right with me. […]
Um, no. The signature of these functions needs to match the type of the `block_erase` function pointer in `struct block_eraser` in `struct flashchip` in flash.h which uses `unsigned int` for `blockaddr` and `blocklen`: https://paste.flashrom.org/view.php?id=3462