Attention is currently required from: Edward O'Callaghan, Arthur Heymans.

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 8:

    
    This was missed because `uint32_t` is `unsigned int` in most cases.
    However, it is not the case for DJGPP 6.1.0 for some reason.
    

    this does not sit right with me. […]

    Um, no. The signature of these functions needs to match the type of the `block_erase` function pointer in `struct block_eraser` in `struct flashchip` in flash.h which uses `unsigned int` for `blockaddr` and `blocklen`: https://paste.flashrom.org/view.php?id=3462

To view, visit change 52473. To unsubscribe, or for help writing mail filters, visit settings.