Attention is currently required from: Nico Huber, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52883 )
Change subject: RFC: flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Further explanation of the reasons for this change: […]
Sorry, I'm not convinced. This looks like a workaround for something only downstream uses.
However, I agree that having to deal with multiple flash chip definitions is annoying. If what downstream needs is to ignore one of the flashchip definitions, why not add a command-line argument to specify flashchip entries to ignore? It would have the same semantics as `-C`. This feature would be useful for everyone, not just downstream.