Attention is currently required from: Nico Huber, Nikolai Artemiev.
Patch set 1:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #1:
Further explanation of the reasons for this change: […]
Sorry, I'm not convinced. This looks like a workaround for something only downstream uses.
However, I agree that having to deal with multiple flash chip definitions is annoying. If what downstream needs is to ignore one of the flashchip definitions, why not add a command-line argument to specify flashchip entries to ignore? It would have the same semantics as `-C`. This feature would be useful for everyone, not just downstream.
To view, visit change 52883. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I688f2e15aef61afbec728a9a81094bee56d6fbfa
Gerrit-Change-Number: 52883
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 04 May 2021 10:09:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Gerrit-MessageType: comment