Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer_delay()
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66373/comment/cd4c2d81_43964403
PS9, Line 11: state. Programmers uses internal delay can provide NULL as a context.
The commit message should mention that only the function signature is changed and that this commit has no functional effect. Also, refer to the commit that makes use of the parameter using `CB:123456`.
File pony_spi.c:
https://review.coreboot.org/c/flashrom/+/66373/comment/ea6a6115_0871463e
PS7, Line 247: flashctx not needed (NULL) because pony_spi does not
: * use it in its delay function.
I would say this is resolvable, what do you think Felix?
A comment at the function declaration that you can pass flashctx but also NULL would be good.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66373
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 9
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Tue, 11 Oct 2022 23:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment