Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.

View Change

2 comments:

• Commit Message:

  • Patch Set #9, Line 11: state. Programmers uses internal delay can provide NULL as a context.

    The commit message should mention that only the function signature is changed and that this commit has no functional effect. Also, refer to the commit that makes use of the parameter using `CB:123456`.

• File pony_spi.c:

  • Patch Set #7, Line 247:

    flashctx not needed (NULL) because pony_spi does not
    			 * use it in its delay function.
    

    I would say this is resolvable, what do you think Felix?

    A comment at the function declaration that you can pass flashctx but also NULL would be good.

To view, visit change 66373. To unsubscribe, or for help writing mail filters, visit settings.