[flashrom-gerrit] Change in flashrom[master]: it85spi.c: Refactor singleton states into reentrant pattern

[Eizan Miyamoto (Code Review)]

Eizan Miyamoto has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )

Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c 
File it85spi.c:

https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c@a76 
PS5, Line 76: #ifdef LPC_IO
            : static unsigned int shm_io_base;
            : #endif
            : 
to satisfy my curiosity, why did we get rid of this preprocessor stuff?

https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c@311 
PS5, Line 311: calloc
nit: Maybe to make it super-obvious, add a comment that the free() of data is handled inside it85xx_shutdown whose call is registered by register_shutdown() below?