View Change
2 comments:
File it85spi.c:
Patch Set #5, Line 76:
#ifdef LPC_IO
static unsigned int shm_io_base;
#endif
to satisfy my curiosity, why did we get rid of this preprocessor stuff?
Patch Set #5, Line 311: calloc
nit: Maybe to make it super-obvious, add a comment that the free() of data is handled inside it85xx_shutdown whose call is registered by register_shutdown() below?
To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I389d34d62e753c012910aa5ff24a496b24a4753c
Gerrit-Change-Number: 47655
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Eizan Miyamoto <eizan@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 24 Nov 2020 02:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment