[flashrom-gerrit] Change in flashrom[master]: flashrom.c: Implement file-based locking semantics

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Hung-Te Lin, Nico Huber, Subrata Banik.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62213 )

Change subject: flashrom.c: Implement file-based locking semantics
......................................................................

Patch Set 2:

(3 comments)

File big_lock.h:

https://review.coreboot.org/c/flashrom/+/62213/comment/aa872d15_c430d0d5 
PS2, Line 1: 2012
> As the commit message suggests, it's not new, just new to this repository.

Only big_lock.c got updated and I put 2022 in there accordingly now. Implementation is not new.

File big_lock.c:

https://review.coreboot.org/c/flashrom/+/62213/comment/37bfa59e_b6e458a5 
PS2, Line 37: firmware_utility_lock
> should this be flashrom_lock ?

Done

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/62213/comment/6c25dcca_8b91bc80 
PS1, Line 142: programmer_entry
> > Not just futility - this is more like "can you run flashrom without getting root permission (requi […]

Locking should fall back to /tmp if /var/run/lock is unavailable. I tested with dummy as non-sudo and it seems to work fine on my system.