Attention is currently required from: Hung-Te Lin, Nico Huber, Subrata Banik.
View Change
3 comments:
File big_lock.h:
Patch Set #2, Line 1: 2012
As the commit message suggests, it's not new, just new to this repository.
Only big_lock.c got updated and I put 2022 in there accordingly now. Implementation is not new.
File big_lock.c:
File flashrom.c:
Patch Set #1, Line 142: programmer_entry
> Not just futility - this is more like "can you run flashrom without getting root permission (requi […]
Locking should fall back to /tmp if /var/run/lock is unavailable. I tested with dummy as non-sudo and it seems to work fine on my system.
To view, visit change 62213. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I19cb4e3bf14caeb67c3e8100a20395b264c5113a
Gerrit-Change-Number: 62213
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte@chromium.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 00:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte@chromium.org>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment