Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46551 )
Change subject: it87spi.c: Prevent use-after-free bug ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/46551/1/it87spi.c File it87spi.c:
https://review.coreboot.org/c/flashrom/+/46551/1/it87spi.c@137 PS1, Line 137: errno != 0 Not sure if it's worth to mention, but we also checked `errno` of `free()` here by accident.
And probably for another patch: Checking `errno` isn't needed at all, as `*param != '\0' && *dualbiosindex_suffix == '\0'` implies success.