Patch set 1:Code-Review +2
View Change
1 comment:
File it87spi.c:
Patch Set #1, Line 137: errno != 0
Not sure if it's worth to mention, but we also checked `errno` of `free()`
here by accident.
And probably for another patch: Checking `errno` isn't needed at all, as
`*param != '\0' && *dualbiosindex_suffix == '\0'` implies success.
To view, visit change 46551. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I79f18f6077c77c0cbb8bfa431e17f9b079f11c95
Gerrit-Change-Number: 46551
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 19 Oct 2020 12:42:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment