Attention is currently required from: Nico Huber, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59741 )
Change subject: tests: Add run_probe_lifecycle and add dummyflasher probe test ......................................................................
Patch Set 5:
(3 comments)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/59741/comment/c9ee987d_347d4baf PS4, Line 28: = NULL
No need to initialize *flashctx. This is done by flashrom_flash_probe.
Done
https://review.coreboot.org/c/flashrom/+/59741/comment/171d18f2_1aa79c1a PS4, Line 34: flashrom_flash_release(flashctx); /* cleanup */
Or aborts `assert_int_equal` the test? […]
Yes, if `assert_int_equal` fails, this terminates the test. In that case `flashrom_flash_release` won't be executed.
Does it mean flashctx still needs to be checked before releasing? (I haven't changed anything yet).
Thanks!
https://review.coreboot.org/c/flashrom/+/59741/comment/b6cf8eb1_e9fbbcf3 PS4, Line 45: = NULL
No need to initialize *flashprog. This is done by flashrom_programmer_init. […]
Done