Attention is currently required from: Nico Huber, Thomas Heijligen.

View Change

3 comments:

• File tests/lifecycle.c:

  • Patch Set #4, Line 28: = NULL

    No need to initialize *flashctx. This is done by flashrom_flash_probe.

    Done

  • Patch Set #4, Line 34: flashrom_flash_release(flashctx); /* cleanup */

    > Or aborts `assert_int_equal` the test? […]

    Yes, if `assert_int_equal` fails, this terminates the test. In that case `flashrom_flash_release` won't be executed.

    Does it mean flashctx still needs to be checked before releasing? (I haven't changed anything yet).

    Thanks!

  • Patch Set #4, Line 45: = NULL

    No need to initialize *flashprog. This is done by flashrom_programmer_init. […]

    Done

To view, visit change 59741. To unsubscribe, or for help writing mail filters, visit settings.