David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31016 ) Change subject: hwaccess: Add endianness converting deserialization functions ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://review.coreboot.org/c/flashrom/+/31016/3/hwaccess.h File hwaccess.h: https://review.coreboot.org/c/flashrom/+/31016/3/hwaccess.h@116 PS3, Line 116: le_to_cpu##bits Shouldn't this be 'endianness##_to_cpu##bits'? -- To view, visit https://review.coreboot.org/c/flashrom/+/31016 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452 Gerrit-Change-Number: 31016 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 02 Dec 2019 00:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment