Attention is currently required from: Felix Singer, Thomas Heijligen, Shreeyash , Alexander Goncharov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ......................................................................
Patch Set 2:
(1 comment)
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/66225/comment/344c5ca9_7efda809 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
Just to make it clear, I have to correct the file for corrections that Thomas, Felix and others mentioned (also in https://review.coreboot.org/c/flashrom/+/67700/) and push the changes to this branch?
Hmmm, the situation is a bit messy... Apologies if this is overwhelming for you.
Both your change and CB:67700 intend to address the same issue. CB:67700 is pretty much ready to go, but Joursoir abandoned it because your change was pushed earlier. We (Angel) are not sure why it was done this way, but looks like deciding how to proceed is in your hands now.
So, would you like to update your change (basically copy CB:67700), or would you prefer Joursoir to restore CB:67700 instead? If unsure, feel free to ask any questions.