Attention is currently required from: Felix Singer, Thomas Heijligen, Shreeyash , Alexander Goncharov.
View Change
1 comment:
File stlinkv3_spi.c:
Patch Set #1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx,
Just to make it clear, I have to correct the file for corrections that Thomas, Felix and others mentioned (also in https://review.coreboot.org/c/flashrom/+/67700/) and push the changes to this branch?
Hmmm, the situation is a bit messy... Apologies if this is overwhelming for you.
Both your change and CB:67700 intend to address the same issue. CB:67700 is pretty much ready to go, but Joursoir abandoned it because your change was pushed earlier. We (Angel) are not sure why it was done this way, but looks like deciding how to proceed is in your hands now.
So, would you like to update your change (basically copy CB:67700), or would you prefer Joursoir to restore CB:67700 instead? If unsure, feel free to ask any questions.
To view, visit change 66225. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f
Gerrit-Change-Number: 66225
Gerrit-PatchSet: 2
Gerrit-Owner: Shreeyash <shreeyash335@gmail.com>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Shreeyash <shreeyash335@gmail.com>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Fri, 14 Oct 2022 10:13:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Shreeyash <shreeyash335@gmail.com>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment