Attention is currently required from: Felix Singer, Nico Huber.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 )
Change subject: ichspi.c: Retype appropiate variables with bool ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/66892/comment/a6ce0d60_35ad5e01 PS7, Line 872: write_cmd = true;
(Also not nice to change the style that the original author choose, IMO.) […]
I think the best summary was made earlier in this thread:
Agree, but that's something for another patch series
This chain is focused on retyping bools, and so let's keep this patch also focused on this. However, good ideas on renaming variables can certainly go into later patches. I don't mind `is_write_command` as a name for variable in question (especially if the variable has type bool).