Attention is currently required from: Felix Singer, Nico Huber.

Patch set 10:Code-Review +2

View Change

1 comment:

• File ichspi.c:

  • Patch Set #7, Line 872: write_cmd = true;

    > > (Also not nice to change the style that the original author choose, IMO.) […]

    I think the best summary was made earlier in this thread:
    > Agree, but that's something for another patch series

    This chain is focused on retyping bools, and so let's keep this patch also focused on this.
    However, good ideas on renaming variables can certainly go into later patches. I don't mind `is_write_command` as a name for variable in question (especially if the variable has type bool).

To view, visit change 66892. To unsubscribe, or for help writing mail filters, visit settings.