Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48064 )
Change subject: sb600spi.c: Remove sb600_spibar out of global state ......................................................................
Patch Set 8: Code-Review+2
(2 comments)
https://review.coreboot.org/c/flashrom/+/48064/8/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/48064/8/sb600spi.c@209 PS8, Line 209: struct sb600spi_data * data It looks like
struct sb600spi_data *data
is the more common style. If it's unlikely for more fields added/used, it may be simpler to pull out sb600_spibar as a local instead.
https://review.coreboot.org/c/flashrom/+/48064/8/sb600spi.c@296 PS8, Line 296: struct sb600spi_data * data = (struct sb600spi_data *)flash->mst->spi.data; Here too.