Patch set 8:Code-Review +2
View Change
2 comments:
File sb600spi.c:
Patch Set #8, Line 209: struct sb600spi_data * data
It looks like
struct sb600spi_data *data
is the more common style. If it's unlikely for more fields added/used, it may be simpler to pull out sb600_spibar as a local instead.
Patch Set #8, Line 296: struct sb600spi_data * data = (struct sb600spi_data *)flash->mst->spi.data;
Here too.
To view, visit change 48064. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2e692b230a77f3902d91d0ad36db0d668b7e9ffa
Gerrit-Change-Number: 48064
Gerrit-PatchSet: 8
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 16 Dec 2020 05:18:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment