Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47089 )
Change subject: chipset_enable.c: Add MCP61 pid=0x03e2 support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47089/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/47089/1//COMMIT_MSG@8
PS1, Line 8:
Where does the ID come from?
According to https://envytools.readthedocs.io/en/latest/hw/pciid.html this is the memory controller PCI ID, not the LPC PCI ID like for all other devices in this list. Is this done on purpose?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id1cb8b77b80c6291886238f91ffb7bf75e5750b3
Gerrit-Change-Number: 47089
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 02 Nov 2020 21:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment