Attention is currently required from: Thomas Heijligen, Angel Pons, Jonathon Hall, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region to par/spi/opaque_master ......................................................................
Patch Set 8: Code-Review+2
(7 comments)
Patchset:
PS2:
Got this reworked, I agree that it's a lot cleaner. […]
I am ok to resolve here.
Patchset:
PS5:
I brought back the SPI master mappers, it was pretty straightforward. […]
I am ok to resolve here.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/c76496f0_f208b98f PS8, Line 222: ( nit: `if (`
https://review.coreboot.org/c/flashrom/+/67695/comment/d507cc79_0db159fb PS8, Line 249: #if CONFIG_INTERNAL == 1 drop this || move inside symbol and make the `master_uses_physmap()` always available (see comment below)?
https://review.coreboot.org/c/flashrom/+/67695/comment/2fd12929_a49b35bf PS8, Line 869: #if CONFIG_INTERNAL == 1 Angel Pons suggested this to me elsewhere but maybe drop the pre-processor if branch here && (see above comment).
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/06d1f5dc_30431b0d PS2, Line 1865: &mapper_phys
Alrighty this is a lot more understandable now! I split this up into several patches and rebased on […]
I am ok to resolve here.
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/1983d826_9c8ae4f1 PS5, Line 919: 1024
We have `MiB` too apparently! Done
Ack