Attention is currently required from: Thomas Heijligen, Angel Pons, Jonathon Hall, Nikolai Artemiev.
Patch set 8:Code-Review +2
7 comments:
Patchset:
Got this reworked, I agree that it's a lot cleaner. […]
I am ok to resolve here.
Patchset:
I brought back the SPI master mappers, it was pretty straightforward. […]
I am ok to resolve here.
File flashrom.c:
nit: `if (`
Patch Set #8, Line 249: #if CONFIG_INTERNAL == 1
drop this || move inside symbol and make the `master_uses_physmap()` always available (see comment below)?
Patch Set #8, Line 869: #if CONFIG_INTERNAL == 1
Angel Pons suggested this to me elsewhere but maybe drop the pre-processor if branch here && (see above comment).
File ichspi.c:
Patch Set #2, Line 1865: &mapper_phys
Alrighty this is a lot more understandable now! I split this up into several patches and rebased on […]
I am ok to resolve here.
File serprog.c:
We have `MiB` too apparently! Done
Ack
To view, visit change 67695. To unsubscribe, or for help writing mail filters, visit settings.