Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35591 )
Change subject: cli_classic: Add convenient '--flash-name' cli opt ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@303 PS1, Line 303: flash_name = 1; Please add a check for mutliple operations specified, like the other operations have it:
if (++operations_specified > 1) { ...
Maybe it's time to put that block into a separate function?
https://review.coreboot.org/c/flashrom/+/35591/1/cli_classic.c@618 PS1, Line 618: msg_ginfo("vendor"%s" name="%s"\n", I wonder if we don't want to use printf() directly. It shouldn't depend on the message level, should it?