Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31012 )
Change subject: cli_classic: Report the gathered layout entries at level dbg
......................................................................
Patch Set 5:
(2 comments)
File layout.c:
https://review.coreboot.org/c/flashrom/+/31012/comment/c178a289_5a24c195
PS4, Line 436: for (struct romentry *entry = l->head; entry; entry = entry->next) {
Please use `layout_next()`.
Kindly borrowed the while-loop from some other function. This also makes the data pointed by `entry` const.
https://review.coreboot.org/c/flashrom/+/31012/comment/780ce972_8a5932fd
PS4, Line 441: msg_gdbg("Total %u entries\n", i);
It feels like we might want a period at the end. I know it's not a complete […]
Added a period and replaced "Total" with "Got"
--
To view, visit
https://review.coreboot.org/c/flashrom/+/31012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7678ba5138f0d722ee44747fe123f192abdd0ffd
Gerrit-Change-Number: 31012
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Fri, 04 Nov 2022 18:57:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment