Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan.

View Change

2 comments:

• File layout.c:

  • Patch Set #4, Line 436: for (struct romentry *entry = l->head; entry; entry = entry->next) {

    Please use `layout_next()`.

    Kindly borrowed the while-loop from some other function. This also makes the data pointed by `entry` const.

  • Patch Set #4, Line 441: msg_gdbg("Total %u entries\n", i);

    It feels like we might want a period at the end. I know it's not a complete […]

    Added a period and replaced "Total" with "Got"

To view, visit change 31012. To unsubscribe, or for help writing mail filters, visit settings.