Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 )
Change subject: s25f.c: implement probing and block erasers for Spansion ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/flashrom/+/46140/1/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/46140/1/Makefile@641 PS1, Line 641: s25f.o
I think this is done now that chip restore has been extracted to a separate patch - or do you want m […]
Ack
https://review.coreboot.org/c/flashrom/+/46140/11/chipdrivers.h File chipdrivers.h:
https://review.coreboot.org/c/flashrom/+/46140/11/chipdrivers.h@23 PS11, Line 23: /*
unrelated change
Ack. Please remember to resolve your comments next time!
https://review.coreboot.org/c/flashrom/+/46140/1/chipdrivers.h File chipdrivers.h:
https://review.coreboot.org/c/flashrom/+/46140/1/chipdrivers.h@24 PS1, Line 24: #include "writeprotect.h" /* for modifier_bits */
It provides the `struct modifier_bits` type used in the s25f prototypes.
Ack
https://review.coreboot.org/c/flashrom/+/46140/2/s25f.c File s25f.c:
https://review.coreboot.org/c/flashrom/+/46140/2/s25f.c@192 PS2, Line 192: unsigned char read_cr_cmd[] = { : CMD_RDAR, : (addr >> 16) & 0xff, : (addr >> 8) & 0xff, : (addr & 0xff), : 0x00, 0x00, 0x00, 0x00, : 0x00, 0x00, 0x00, 0x00, : };
I've updated this one. I'm not sure what the indent levels should be for the others (e.g. […]
Ack
https://review.coreboot.org/c/flashrom/+/46140/4/s25f.c File s25f.c:
https://review.coreboot.org/c/flashrom/+/46140/4/s25f.c@487 PS4, Line 487: int probe_spi_big_spansion(struct flashctx *flash)
n.b. I have changed this function quite a bit: […]
Ack