View Change

5 comments:

• File Makefile:

  • Patch Set #1, Line 641: s25f.o

    I think this is done now that chip restore has been extracted to a separate patch - or do you want m […]

    Ack

• File chipdrivers.h:

  • Patch Set #11, Line 23: /*

    unrelated change

    Ack. Please remember to resolve your comments next time!

• File chipdrivers.h:

  • Patch Set #1, Line 24: #include "writeprotect.h" /* for modifier_bits */

    It provides the `struct modifier_bits` type used in the s25f prototypes.

    Ack

• File s25f.c:

  • Patch Set #2, Line 192:

    unsigned char read_cr_cmd[] = {
    					CMD_RDAR,
    					(addr >> 16) & 0xff,
    					(addr >> 8) & 0xff,
    					(addr & 0xff),
    					0x00, 0x00, 0x00, 0x00,
    					0x00, 0x00, 0x00, 0x00,
    	};
    

    I've updated this one. I'm not sure what the indent levels should be for the others (e.g. […]

    Ack

• File s25f.c:

  • Patch Set #4, Line 487: int probe_spi_big_spansion(struct flashctx *flash)

    n.b. I have changed this function quite a bit: […]

    Ack

To view, visit change 46140. To unsubscribe, or for help writing mail filters, visit settings.